Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Enable AVX512 compiler support when available. #2184

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

ggorman
Copy link
Contributor

@ggorman ggorman commented Aug 9, 2023

Use configuration['platform'].isa == 'avx512' to determine whether AVX512 is supported rather than DEVITO_PLATFORM. This adds compiler options for long vectors for Intel Skylake and later generations.

@ggorman ggorman requested a review from FabioLuporini August 9, 2023 11:12
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2184 (c0d920a) into master (7caa50c) will increase coverage by 0.00%.
Report is 11 commits behind head on master.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##           master    #2184   +/-   ##
=======================================
  Coverage   87.08%   87.09%           
=======================================
  Files         226      226           
  Lines       40175    40178    +3     
  Branches     7331     7332    +1     
=======================================
+ Hits        34988    34992    +4     
  Misses       4606     4606           
+ Partials      581      580    -1     
Files Changed Coverage Δ
devito/arch/compiler.py 39.37% <60.00%> (+0.46%) ⬆️
devito/arch/archinfo.py 42.43% <100.00%> (+0.12%) ⬆️

…whether AVX512 is supported rather than DEVITO_PLATFORM. This adds compiler options for long vectors for Intel Skylake and later generations.
@mloubout mloubout added the arch jitting, archinfo, ... label Aug 9, 2023
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stronger

@@ -698,7 +698,6 @@ class IntelCompiler(Compiler):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

platform = kwargs.pop('platform', configuration['platform'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this back, and same for GCC one

@FabioLuporini FabioLuporini merged commit ca2960d into master Aug 9, 2023
@FabioLuporini FabioLuporini deleted the intel_compiler branch August 9, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch jitting, archinfo, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants