Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl: prevent aggregation for symbolic coefficients #2182

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Aug 6, 2023

Fixes #2181

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #2182 (3b9091a) into master (bc4d02d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2182      +/-   ##
==========================================
- Coverage   87.09%   87.09%   -0.01%     
==========================================
  Files         226      226              
  Lines       40160    40172      +12     
  Branches     7329     7330       +1     
==========================================
+ Hits        34979    34987       +8     
- Misses       4602     4605       +3     
- Partials      579      580       +1     
Files Changed Coverage Δ
devito/parameters.py 85.10% <100.00%> (ø)
devito/passes/equations/linearity.py 100.00% <100.00%> (ø)
tests/test_symbolic_coefficients.py 99.10% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

@mloubout mloubout force-pushed the custom-fd-fix-2 branch 3 times, most recently from 3ce3042 to 87ea50d Compare August 7, 2023 14:26
@mloubout mloubout force-pushed the custom-fd-fix-2 branch 6 times, most recently from 5258f7a to 0d5b1ae Compare August 8, 2023 02:38
@mloubout mloubout merged commit a1506b6 into master Aug 8, 2023
@mloubout mloubout deleted the custom-fd-fix-2 branch August 8, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom coeffs errors when aggregated
2 participants