Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: prevent factorization for symbolic coefficients #2179

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Aug 3, 2023

Fixes #2178

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2179 (bcdae34) into master (a7a7e1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2179   +/-   ##
=======================================
  Coverage   87.09%   87.10%           
=======================================
  Files         226      226           
  Lines       40136    40148   +12     
  Branches     7324     7325    +1     
=======================================
+ Hits        34957    34969   +12     
  Misses       4600     4600           
  Partials      579      579           
Files Changed Coverage Δ
devito/passes/equations/linearity.py 100.00% <100.00%> (ø)
tests/test_symbolic_coefficients.py 99.06% <100.00%> (+0.04%) ⬆️

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncontroversial

@mloubout mloubout force-pushed the collect-deriv-fix branch from b837e00 to bcdae34 Compare August 3, 2023 21:28
@mloubout mloubout merged commit 0abe395 into master Aug 4, 2023
@mloubout mloubout deleted the collect-deriv-fix branch August 4, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbolic coefficient erroring due to factorization
3 participants