builtins: Support batched initialize_function #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
+ Coverage 87.06% 87.08% +0.01%
==========================================
Files 228 228
Lines 40539 40579 +40
Branches 7412 7419 +7
==========================================
+ Hits 35295 35337 +42
Misses 4642 4642
+ Partials 602 600 -2
... and 1 file with indirect coverage changes 📢 Have feedback on the report? Share it here. |
mloubout
reviewed
Aug 1, 2023
| if isinstance(function, dv.TimeFunction): | ||
| if isinstance(function, (list, tuple)): | ||
| if not isinstance(data, (list, tuple)): | ||
| raise TypeError("Expected a list of `data`") |
There was a problem hiding this comment.
I think we could support this case for init([f,g,h], data) (ie all function initialized to smae data) with just data = [data]*len(function)
devito/builtins/initializers.py
Outdated
| nbl, slices = nbl_to_padsize(nbl, function.ndim) | ||
| if isinstance(data, dv.Function): | ||
| function.data[slices] = data.data[:] | ||
| for f in functions: |
There was a problem hiding this comment.
for (f, d) in zip(functions, datas)
devito/builtins/initializers.py
Outdated
|
|
||
| assign(lhs, rhs, options=options, name=name, **kwargs) | ||
| name = name or 'pad_%s' % '_'.join(f.name for f in functions) |
There was a problem hiding this comment.
would use "init" instead of pad as the generic case
| (len(function), len(data))) | ||
|
|
||
| if mapper is not None: | ||
| raise NotImplementedError("Unsupported `mapper` with batching") |
There was a problem hiding this comment.
Not even one mapper per function?
tests/test_builtins.py
Outdated
|
|
||
| f = Function(name='f', grid=grid, dtype=np.int32) | ||
| g = Function(name='g', grid=grid, dtype=np.int32) | ||
| h = Function(name='h', grid=grid, dtype=np.int32) |
There was a problem hiding this comment.
Would mix dtype to test "general" case
FabioLuporini
force-pushed
the
builtin-batching
branch
from
2bd0034 to
9b9edb5
Compare
mloubout
force-pushed
the
builtin-batching
branch
2 times, most recently
from
9b7282a to
1637084
Compare
mloubout
force-pushed
the
builtin-batching
branch
from
1637084 to
4f62b4d
Compare
mloubout
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.