arch: Correct march to mcpu for ppc
#2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
reviewed
Jul 27, 2023
devito/arch/compiler.py
Outdated
| @@ -396,6 +396,12 @@ def __init__(self, *args, **kwargs): | |||
| # from `=512` | |||
| self.cflags.append('-mprefer-vector-width=512') | |||
|
|
|||
| if platform in [POWER8, POWER9]: | |||
| # -march isn't supported on power architectures | |||
There was a problem hiding this comment.
Indentation looks off, will break CI
raminammour
changed the title
march to mcpu for ppcmarch to mcpu for ppc
|
Thanks -- content is uncontroversial! As @mloubout suggested, could you rebase to honor our commit message format? Thanks a lot |
| @@ -382,7 +382,7 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| platform = kwargs.pop('platform', configuration['platform']) | |||
|
|
|||
| self.cflags += ['-march=native', '-Wno-unused-result', | |||
| self.cflags += ['-Wno-unused-result', | |||
There was a problem hiding this comment.
This may also break flake8?
Codecov Report
@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
- Coverage 87.09% 87.08% -0.01%
==========================================
Files 226 226
Lines 40172 40175 +3
Branches 7330 7331 +1
==========================================
+ Hits 34987 34988 +1
- Misses 4605 4606 +1
- Partials 580 581 +1
|
|
Rebase onto master with a single commit (the last one is good) and GTG |
Switch between -march=native (x86) and -mcpu=native -mtune=native (PowerPC) Costmetic changes so `mcpu` and `march` remain the first flag Fix indentation arch: Correct march to mcpu for ppc Correcting commit message since editing the title on github webui wasn't enough (I couldn't figure out how to rebase from the webui, sorry!). Maybe you can squash to this commit when merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a very minor change: Switch between -march=native (x86) and -mcpu=native -mtune=native (PowerPC)
fixes #2146
I am not sure if you are testing on PPC (I guess not since the error never showed up) so not sure what to do for an appropriate test.