Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: prevent Eq dims to be lost if only implicit #2169

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

mloubout
Copy link
Contributor

No description provided.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncontroversial

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #2169 (4759473) into master (0adb92e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   87.03%   87.03%   -0.01%     
==========================================
  Files         223      223              
  Lines       39964    39975      +11     
  Branches     7301     7302       +1     
==========================================
+ Hits        34784    34793       +9     
- Misses       4599     4600       +1     
- Partials      581      582       +1     
Impacted Files Coverage Δ
devito/ir/clusters/cluster.py 94.34% <100.00%> (+0.02%) ⬆️
tests/test_dse.py 99.80% <100.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

@mloubout mloubout force-pushed the implicit-dim-no-eq branch from 321c6dd to 4759473 Compare July 24, 2023 14:13
@mloubout mloubout merged commit 65dc7d8 into master Jul 24, 2023
@mloubout mloubout deleted the implicit-dim-no-eq branch July 24, 2023 17:10
@deckerla
Copy link
Contributor

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants