Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add python 3.11 and minor CI fixing #2158

Merged
merged 3 commits into from
Jul 20, 2023
Merged

ci: Add python 3.11 and minor CI fixing #2158

merged 3 commits into from
Jul 20, 2023

Conversation

georgebisbas
Copy link
Contributor

@georgebisbas georgebisbas commented Jul 3, 2023

No description provided.

@georgebisbas georgebisbas added the CI continuous integration label Jul 3, 2023
@georgebisbas georgebisbas self-assigned this Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #2158 (cfc2710) into master (9466a03) will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##           master    #2158     +/-   ##
=========================================
  Coverage   87.04%   87.04%             
=========================================
  Files         223      223             
  Lines       39946    39946             
  Branches     5177     7295   +2118     
=========================================
  Hits        34769    34769             
  Misses       4598     4598             
  Partials      579      579             
Impacted Files Coverage Δ
devito/tools/utils.py 83.56% <50.00%> (ø)

docker/Dockerfile.cpu Outdated Show resolved Hide resolved
.github/workflows/pytest-core-nompi.yml Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@georgebisbas georgebisbas changed the title ci: Drop python 3.7, add python 3.11 ci: Update docket to 3.8, add python 3.11 Jul 4, 2023
@georgebisbas georgebisbas changed the title ci: Update docket to 3.8, add python 3.11 ci: Update docker to 3.8, add python 3.11 Jul 4, 2023
.github/workflows/pytest-core-nompi.yml Outdated Show resolved Hide resolved
docker/Dockerfile.cpu Outdated Show resolved Hide resolved
.github/workflows/pytest-core-nompi.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with all those notebook changes

@@ -87,7 +87,7 @@ jobs:
python examples/cfd/example_diffusion.py

- name: Upload coverage to Codecov
if: matrix.name != 'pytest-docker-py37-gcc-omp'
if: matrix.name != 'pytest-docker-py38-gcc-omp'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right, there is no pytest or matrix name in this workflow it's only run once, if should be removed

docker/Dockerfile.cpu Outdated Show resolved Hide resolved
@georgebisbas
Copy link
Contributor Author

What's going on with all those notebook changes

There is some different latex printing adding this \operatorname

@georgebisbas georgebisbas changed the title ci: Update docker to 3.8, add python 3.11 ci: Update docker to 3.9, add python 3.11 Jul 7, 2023
@georgebisbas georgebisbas requested a review from EdCaunt July 7, 2023 15:50
@georgebisbas georgebisbas force-pushed the docker_python_38 branch 3 times, most recently from 11d7cc2 to 8460a63 Compare July 18, 2023 08:02
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR, but minor addition

@georgebisbas georgebisbas force-pushed the docker_python_38 branch 3 times, most recently from 2e0e33a to 3cc77f5 Compare July 18, 2023 08:39
Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change the tutorials it's unnecessary diff

@@ -86,7 +86,7 @@ jobs:
python examples/cfd/example_diffusion.py

- name: Upload coverage to Codecov
if: matrix.name != 'pytest-docker-py37-gcc-omp'
if: matrix.name != 'pytest-docker-py39-gcc-omp'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover delete line

@georgebisbas georgebisbas changed the title ci: Update docker to 3.9, add python 3.11 ci: Add python 3.11 and minor CI fixing Jul 20, 2023
@mloubout mloubout merged commit a4ea4a1 into master Jul 20, 2023
@mloubout mloubout deleted the docker_python_38 branch July 20, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants