-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add python 3.11 and minor CI fixing #2158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
=========================================
Coverage 87.04% 87.04%
=========================================
Files 223 223
Lines 39946 39946
Branches 5177 7295 +2118
=========================================
Hits 34769 34769
Misses 4598 4598
Partials 579 579
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
060fbb2
to
19fa028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's going on with all those notebook changes
.github/workflows/examples.yml
Outdated
@@ -87,7 +87,7 @@ jobs: | |||
python examples/cfd/example_diffusion.py | |||
|
|||
- name: Upload coverage to Codecov | |||
if: matrix.name != 'pytest-docker-py37-gcc-omp' | |||
if: matrix.name != 'pytest-docker-py38-gcc-omp' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't right, there is no pytest or matrix name in this workflow it's only run once, if should be removed
dae1296
to
d305eb5
Compare
There is some different latex printing adding this \operatorname |
36adeff
to
c56c36a
Compare
11d7cc2
to
8460a63
Compare
devito/tools/utils.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this PR, but minor addition
2e0e33a
to
3cc77f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't change the tutorials it's unnecessary diff
.github/workflows/examples.yml
Outdated
@@ -86,7 +86,7 @@ jobs: | |||
python examples/cfd/example_diffusion.py | |||
|
|||
- name: Upload coverage to Codecov | |||
if: matrix.name != 'pytest-docker-py37-gcc-omp' | |||
if: matrix.name != 'pytest-docker-py39-gcc-omp' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover delete line
3cc77f5
to
ebe91fe
Compare
No description provided.