compiler: Fix pickling of aliasing SparseFunction #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
=======================================
Coverage 87.07% 87.08%
=======================================
Files 223 223
Lines 39832 39847 +15
Branches 5169 5169
=======================================
+ Hits 34685 34702 +17
+ Misses 4569 4568 -1
+ Partials 578 577 -1
|
georgebisbas
approved these changes
Jun 17, 2023
mloubout
reviewed
Jun 17, 2023
| @@ -488,7 +488,10 @@ def coordinates(self): | |||
|
|
|||
| @property | |||
| def coordinates_data(self): | |||
| return self.coordinates.data.view(np.ndarray) | |||
| try: | |||
| return self.coordinates.data.view(np.ndarray) | |||
There was a problem hiding this comment.
since it gets fixed in your PR, I'm merging
mloubout
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.