compiler: Add opkwargs property to ArgumentsMap #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
reviewed
Jun 8, 2023
| temp_registry = {v: k for k, v in compiler_registry.items()} | ||
| compiler = temp_registry[self.compiler.__class__] | ||
|
|
||
| return {'platform': platform, 'compiler': compiler, 'language': self.language} |
There was a problem hiding this comment.
Why not self.compiler and self.platform
opkwargs is a bit vague since it only returns the "language" part
There was a problem hiding this comment.
self.compiler and self.platform contain Compiler and Platform objects respectively instead of the original str arguments passed to the operator. Downstream operators will expect arguments passed to them to be str's
Is there a Devito word that encompasses platform, compiler, and language to use a more descriptive method name?
FabioLuporini
approved these changes
Jun 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #2142 +/- ##
==========================================
- Coverage 87.09% 87.08% -0.02%
==========================================
Files 223 223
Lines 39871 39878 +7
Branches 5170 5172 +2
==========================================
+ Hits 34726 34728 +2
- Misses 4568 4573 +5
Partials 577 577
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds
opkwargsproperty toArgumentsMap.opkwargsreturns a dictionary containing compiler, language and platform keyword arguments usable by downstream operators.