compiler: Revert "compiler: Relax WaitLock regions in a ScheduleTree" #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4a184e0.
Codecov Report
@@ Coverage Diff @@
## master #2141 +/- ##
==========================================
+ Coverage 87.08% 87.10% +0.02%
==========================================
Files 223 223
Lines 39830 39813 -17
Branches 5168 5166 -2
==========================================
- Hits 34685 34679 -6
+ Misses 4567 4556 -11
Partials 578 578
|
FabioLuporini
commented
Jun 8, 2023
| @@ -1168,7 +1168,7 @@ def _as_number(self, v, args): | |||
| else: | |||
| assert self.target.c0.is_Array | |||
| assert args is not None | |||
| return int(v.subs(args)) | |||
| return int(subs_op_args(v, args)) | |||
There was a problem hiding this comment.
sympy 1.12 patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4a184e0.
Explanation: this was done only to change the profiling scope of the WaitLock regions . However, it turns out it breaks code generation in CUDA/HIP + streaming. Hence, reverting for now, until I will have the time to find a better solution