deps: sympy 1.12 compat #2123
Merged
deps: sympy 1.12 compat #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2123 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 220 220
Lines 39300 39307 +7
Branches 5113 5114 +1
=======================================
+ Hits 34251 34258 +7
Misses 4478 4478
Partials 571 571
|
georgebisbas
approved these changes
May 11, 2023
mloubout
commented
May 11, 2023
| @@ -273,6 +274,14 @@ def calculate_nblocks(tree, blockable): | |||
|
|
|||
|
|
|||
| def generate_block_shapes(blockable, args, level): | |||
| # Make sure all params are substitutable (ie cannot raise SympifyError) | |||
There was a problem hiding this comment.
Note: I know this is not the pretiest but this errors in the latest sympy because we have some CParams in there that are not sympify-able, see here for new sympy behavior
FabioLuporini
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.