Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Fix OpenMP reductions in tandem with linearize=True #2117

Merged
merged 5 commits into from
May 2, 2023

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

@FabioLuporini FabioLuporini added the bug-C bug in the generated code label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2117 (021e425) into master (e6f25d5) will increase coverage by 0.00%.
The diff coverage is 94.21%.

@@           Coverage Diff            @@
##           master    #2117    +/-   ##
========================================
  Coverage   87.71%   87.72%            
========================================
  Files         221      220     -1     
  Lines       39030    39151   +121     
  Branches     5075     5097    +22     
========================================
+ Hits        34236    34345   +109     
- Misses       4232     4242    +10     
- Partials      562      564     +2     
Impacted Files Coverage Δ
devito/ir/support/properties.py 81.30% <ø> (-0.30%) ⬇️
devito/passes/iet/languages/openacc.py 62.03% <42.85%> (-3.51%) ⬇️
devito/passes/iet/linearization.py 82.93% <90.47%> (+0.83%) ⬆️
devito/passes/iet/parpragma.py 89.01% <98.24%> (+1.39%) ⬆️
devito/core/autotuning.py 93.85% <100.00%> (+0.10%) ⬆️
devito/ir/iet/nodes.py 91.98% <100.00%> (-0.33%) ⬇️
devito/ir/support/__init__.py 100.00% <100.00%> (ø)
devito/ir/support/syncs.py 60.31% <100.00%> (-1.23%) ⬇️
devito/ir/support/utils.py 86.50% <100.00%> (+0.16%) ⬆️
devito/passes/iet/languages/openmp.py 88.11% <100.00%> (-3.70%) ⬇️
... and 1 more

... and 8 files with indirect coverage changes

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine

@FabioLuporini FabioLuporini merged commit 08e8d95 into master May 2, 2023
@FabioLuporini FabioLuporini deleted the fix-inc-omp branch May 2, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-C bug in the generated code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants