-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: Improve lowering of IndexDerivatives #2112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2112 +/- ##
==========================================
+ Coverage 87.09% 87.14% +0.04%
==========================================
Files 222 223 +1
Lines 39523 39647 +124
Branches 5127 5139 +12
==========================================
+ Hits 34424 34550 +126
Misses 4521 4521
+ Partials 578 576 -2
|
FabioLuporini
force-pushed
the
parlang-after-cire
branch
from
April 19, 2023 08:41
959cbb4
to
62414bb
Compare
FabioLuporini
force-pushed
the
parlang-after-cire
branch
from
May 2, 2023 13:32
62414bb
to
60d76e2
Compare
georgebisbas
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good to my eyes
mloubout
approved these changes
May 9, 2023
FabioLuporini
force-pushed
the
parlang-after-cire
branch
from
May 16, 2023 07:16
60d76e2
to
c258164
Compare
This fixes DDA with Buffer(2) due to t-1 and t+1 mapped to the same ModuloDimension
FabioLuporini
force-pushed
the
parlang-after-cire
branch
from
May 31, 2023 07:14
c258164
to
8077f6e
Compare
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More use cases covered, better generated code (e.g. more fusion).
PR equipped with tests