install: Overhaul Dockerfile.amd for MPI support #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
- Coverage 87.77% 87.75% -0.02%
==========================================
Files 221 221
Lines 39003 39010 +7
Branches 5067 5068 +1
==========================================
Hits 34233 34233
- Misses 4208 4215 +7
Partials 562 562
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
georgebisbas
approved these changes
Apr 14, 2023
docker/Dockerfile.amd
Outdated
|
|
||
| # Build mpi4py against amdclang | ||
| RUN python3 -m venv /venv && \ | ||
| RUN which mpicc && \ |
There was a problem hiding this comment.
Would it hurt to keep?
There was a problem hiding this comment.
we can drop which mpicc yeah
mloubout
requested changes
Apr 14, 2023
FabioLuporini
commented
Apr 18, 2023
docker/Dockerfile.amd
Outdated
|
|
||
| # Build mpi4py against amdclang | ||
| RUN python3 -m venv /venv && \ | ||
| RUN which mpicc && \ |
There was a problem hiding this comment.
we can drop which mpicc yeah
FabioLuporini
commented
Apr 20, 2023
mloubout
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.