install: Use amd maintained base for mpi/ucx/... #2098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
===========================================
- Coverage 87.80% 63.02% -24.79%
===========================================
Files 221 142 -79
Lines 38665 21695 -16970
Branches 5000 3924 -1076
===========================================
- Hits 33951 13673 -20278
- Misses 4164 7314 +3150
- Partials 550 708 +158 see 188 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
It gives me some weird permission error locally not sure why but yeah seem like the "nicer" way to do it without caring about maintaining a base |
mloubout
force-pushed
the
amd-docker-base
branch
3 times, most recently
from
424e9d3 to
37777c0
Compare
mloubout
force-pushed
the
amd-docker-base
branch
2 times, most recently
from
68e540b to
4b2d1f6
Compare
mloubout
force-pushed
the
amd-docker-base
branch
2 times, most recently
from
9b04065 to
4e17a4b
Compare
mloubout
force-pushed
the
amd-docker-base
branch
from
4e17a4b to
cebcaa1
Compare
FabioLuporini
changed the title
mloubout
commented
Apr 14, 2023
| '-Xopenmp-target=amdgcn-amd-amdhsa'] | ||
| self.ldflags += ['-march=%s' % platform.march] | ||
| self.ldflags += ['-fopenmp'] | ||
| self.ldflags += ['--offload-arch=%s' % platform.march] |
| @@ -701,7 +701,7 @@ def march(cls): | |||
| # mygpu will only print values accepted by cuda clang in | |||
| # the clang argument --cuda-gpu-arch. | |||
| try: | |||
| p1 = Popen(['mygpu', '-d', 'gfx900'], stdout=PIPE, stderr=PIPE) | |||
| p1 = Popen(['/opt/rocm-5.4.2/llvm/bin/offload-arch'], stdout=PIPE, stderr=PIPE) | |||
|
Superseeded by #2104, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be tested but that should work (it build locally at least)