Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Build icx docker image #2097

Closed
wants to merge 1 commit into from
Closed

Conversation

georgebisbas
Copy link
Contributor

@georgebisbas georgebisbas commented Mar 31, 2023

To build a docker image that will be used for testing #2051

@georgebisbas georgebisbas added CI continuous integration installation labels Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2097 (87cc68c) into master (d0e705d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files         221      221           
  Lines       38665    38665           
  Branches     5000     5000           
=======================================
  Hits        33951    33951           
  Misses       4164     4164           
  Partials      550      550           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mloubout
Copy link
Contributor

I think it's quite overkill as can just use a common intel docker and call it with -e DEVITO_ARCH=icx/icc I don't mind renaming the cpu-icc to cpu-intel and then just have the runtime choice

@FabioLuporini FabioLuporini deleted the icx_docker_image branch April 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants