-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reqs: Fix for matplotlib >=3.6.3 #2047
Conversation
What is breaking? So that we know if someone comes up with the same issue. |
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 221 221
Lines 39135 39135
Branches 5094 5094
=======================================
Hits 34334 34334
Misses 4238 4238
Partials 563 563 |
updated, it is a plotting issue, as used in a few notebooks |
why is it breaking? |
So, current CI, does not update matplotlib.
This: |
ac520e3
to
7cb9e98
Compare
.github/workflows/tutorials.yml
Outdated
@@ -86,7 +86,7 @@ jobs: | |||
run: | | |||
python -m pip install --upgrade pip | |||
pip install -e . | |||
pip install matplotlib blosc | |||
pip install --upgrade matplotlib blosc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should just be pip install -e .[extras]
7cb9e98
to
d071183
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restricting matplotlib doesn't sound like a good idea
Another story the fact that matplotlib shouldn't even be a strict dependency
40ed9a9
to
c343b59
Compare
Does it work with earlier versions as well? |
c343b59
to
e43806b
Compare
e43806b
to
1e4d200
Compare
Temporary fix to avoid breaking since this update...