compiler: Fix subdim argument mismatch #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
- Coverage 87.78% 87.78% -0.01%
==========================================
Files 214 214
Lines 37017 37039 +22
Branches 5573 5577 +4
==========================================
+ Hits 32496 32515 +19
- Misses 4000 4003 +3
Partials 521 521
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FabioLuporini
changed the title
mloubout
force-pushed
the
fix-subdim-mismatch
branch
3 times, most recently
from
f79c01a to
af3d517
Compare
mloubout
force-pushed
the
fix-subdim-mismatch
branch
3 times, most recently
from
e96aec7 to
8385cf1
Compare
mloubout
force-pushed
the
fix-subdim-mismatch
branch
from
8385cf1 to
651e12c
Compare
Comment on lines
-644
to
-645
| """ | ||
| Generate C code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #2018
Fix a small corner case where you can end with something like
[nt, frozenset{nt, nt+1, ...}]needing to be reduced/unique'ed with subdimensions and apply overrides.