-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return slice(0,-1) for glb_slices if glb_numb empty on an mpi rank #2004
Conversation
Closes #2003 |
Line 2336 in 6e1dcc5
|
No this is the "main" to debug, i.e so that you can run Line 364 in 6e1dcc5
|
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 214 214
Lines 36710 36713 +3
Branches 5550 5550
=======================================
+ Hits 32250 32253 +3
Misses 3942 3942
Partials 518 518
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c6e184d
to
96db672
Compare
@mloubout thanks for the advice! most recent push includes modified unit test covering the behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks.
One minor CI comment but should be goog to go
96db672
to
e1e2bef
Compare
No description provided.