gpu: Update to HPC 22.3, reduced image size #1918
Conversation
| # | ||
| # docker run --gpus all --rm -it -p 8888:8888 -p 8787:8787 -p 8786:8786 --device=/dev/infiniband/uverbs0 --device=/dev/infiniband/rdma_cm devito:nvidia | ||
| # | ||
| # to run in user context on a cluster with shared filesystem, you can add the correct user config as docker options e.g.: | ||
| # docker run --gpus all --rm -it -v `pwd`:`pwd` -w `pwd` -u $(id -u):$(id -g) devito:nvidia python examples/seismic/acoustic/acoustic_example.py | ||
| # | ||
| ############################################################## | ||
| FROM python:3.8 | ||
| #FROM python:3.9 |
There was a problem hiding this comment.
Are the comments to be removed?
There was a problem hiding this comment.
I was just try to illustrate that there was an alternate non-slim version of the base container. #FROM python:3.9 could be removed, yes.
There was a problem hiding this comment.
I think, the slimmer, the better right?
There was a problem hiding this comment.
That is the ask from some of our the users of the container.
| # | ||
| # docker run --gpus all --rm -it -p 8888:8888 -p 8787:8787 -p 8786:8786 --device=/dev/infiniband/uverbs0 --device=/dev/infiniband/rdma_cm devito:nvidia | ||
| # | ||
| # to run in user context on a cluster with shared filesystem, you can add the correct user config as docker options e.g.: | ||
| # docker run --gpus all --rm -it -v `pwd`:`pwd` -w `pwd` -u $(id -u):$(id -g) devito:nvidia python examples/seismic/acoustic/acoustic_example.py | ||
| # | ||
| ############################################################## | ||
| FROM python:3.8 | ||
| #FROM python:3.9 |
There was a problem hiding this comment.
I think, the slimmer, the better right?
docker/Dockerfile.nvidia
Outdated
| curl -sL https://deb.nodesource.com/setup_12.x | bash - && \ | ||
| apt-get install -y -q \ | ||
| nodejs \ | ||
| # nvhpc-22-3-cuda-multi \ |
There was a problem hiding this comment.
Not need in most cases. Commented out for a smaller slimmer container
There was a problem hiding this comment.
Can you remind us what's cuda-multi for?
There was a problem hiding this comment.
Two previous cuda version and everythng that goes with it. Takes a lot of space usually yeah and not needed.
FabioLuporini
changed the title
docker/Dockerfile.nvidia
Outdated
| curl -sL https://deb.nodesource.com/setup_12.x | bash - && \ | ||
| apt-get install -y -q \ | ||
| nodejs \ | ||
| # nvhpc-22-3-cuda-multi \ |
There was a problem hiding this comment.
Can you remind us what's cuda-multi for?
docker/Dockerfile.nvidia
Outdated
| curl -sL https://deb.nodesource.com/setup_12.x | bash - && \ | ||
| apt-get install -y -q \ | ||
| nodejs \ | ||
| # nvhpc-22-3-cuda-multi \ | ||
| nvhpc-22-3 \ |
There was a problem hiding this comment.
Sorry it took a while to get to this PR, my bad... but now that we're here, we could also do 22-5 , right?
|
Could we make this automatic somehow with a cron workflow to avoid the effort and PRs. Like just check once a week if there is a new sdk and update the image |
That's a lovely idea -- tho that's probably on us ;) |
|
@mloubout @georgebisbas can you make any sense of the conflict with the existing Dockerfile.nvidia ? |
I wonder whether this conflict comes from @kenhester 's fork? |
|
Conflict is from the changes to dockerfile that were made in between yes since the COPY has slightly changed. |
Codecov Report
@@ Coverage Diff @@
## master #1918 +/- ##
==========================================
- Coverage 89.60% 88.85% -0.76%
==========================================
Files 211 211
Lines 36077 36077
Branches 5425 5425
==========================================
- Hits 32326 32055 -271
- Misses 3248 3506 +258
- Partials 503 516 +13
Continue to review full report at Codecov.
|
|
Should be GTG |
|
Thanks a lot @kenhester ! Merging, sorry it took a while, we have had a long list of PRs in the queue |
No description provided.