compiler: Misc minor code generation fixes #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1891 +/- ##
========================================
Coverage 89.63% 89.64%
========================================
Files 210 210
Lines 35265 35453 +188
Branches 5319 5350 +31
========================================
+ Hits 31611 31781 +170
- Misses 3161 3179 +18
Partials 493 493
Continue to review full report at Codecov.
|
mloubout
approved these changes
Mar 28, 2022
| If at least one Cluster performs floating point arithmetic, then the | ||
| Clusters performing integer arithmetic are ignored. | ||
|
|
||
| If two Clusters perform calculations with different precision, the |
FabioLuporini
force-pushed
the
enable-local-buffering
branch
4 times, most recently
from
da8474a to
dd85aa0
Compare
mloubout
reviewed
Mar 30, 2022
devito/arch/archinfo.py
Outdated
| @memoized_func | ||
| def get_cuda_path(): | ||
| # *** First try: CUDA_HOME | ||
| cuda_home = os.environ.get('CUDA_HOME') |
There was a problem hiding this comment.
would try CUDA_ROOT as well
FabioLuporini
force-pushed
the
enable-local-buffering
branch
5 times, most recently
from
65d706b to
f1f5948
Compare
FabioLuporini
changed the title
georgebisbas
reviewed
Apr 6, 2022
devito/symbolics/extended_sympy.py
Outdated
| @@ -170,6 +180,17 @@ def base(self): | |||
| else: | |||
| return self.pointer | |||
|
|
|||
| @property | |||
| def bound_symbols(self): | |||
| # NOTE: this property requires the prefix '_' in front because | |||
There was a problem hiding this comment.
But you are not using it right? the prefix _
FabioLuporini
force-pushed
the
enable-local-buffering
branch
from
e2faf0d to
9cc634f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.