Fix halo update hoisting #1494
Merged
Fix halo update hoisting #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
So turns out you have a nice patch after all?
Do all tests pass?
Can you add all of the new tests that you've shown in #1483 ?
devito/passes/iet/mpi.py
Outdated
| # E.g., `dep=W<f,[x]> -> R<f,[x-1]>` and `candidates=(time, x)` => False | ||
| # E.g., `dep=W<f,[t1, x, y]> -> R<f,[t0, x-1, y+1]>`, `dep.cause={t,time}` and | ||
| # `candidates=(x,)` => True | ||
| return (all(d in dep.distance_mapper for d in candidates) and | ||
| not dep.cause & candidates) | ||
| not dep.cause & candidates and | ||
| not loc_dims & candidates) |
There was a problem hiding this comment.
this looks about the right thing to do
FabioLuporini
requested changes
Nov 9, 2020
Merge conflicts in devito/passes/iet/mpi.py
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #1483