-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outhalo size warning #1493
Outhalo size warning #1493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
- Coverage 86.52% 86.50% -0.02%
==========================================
Files 197 197
Lines 28504 28506 +2
Branches 3873 3875 +2
==========================================
- Hits 24662 24660 -2
- Misses 3408 3411 +3
- Partials 434 435 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, any way to test it?
I'm not sure I understand the fix. |
For |
I was thinking about that, but came to the conclusion that a specific test was overkill. The incorrect warning currently (<- current master) shows up for the mpi seismic examples, but I'm not sure we wan't to play around with them or add a 'dummy' example that currently erronously produces the warning? |
Thanks, merged. |
Tiny PR to fix #1466 .