Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced the drawmaps.py demo so that it renders things as colored circles. #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

selliott512
Copy link

I thought it might be nice if things were visible in the image produced. Maybe a command line argument could be added to make the things optional, but it's just a demo. It can be modified by the user based on their needs.

…rcles.

The relationship between the thing type to thing color is random but consistent.
@selliott512
Copy link
Author

Here's an example of an image. It's MAP05 from the Freedoom project with width 800.
map05-from-omgifol

@ghost
Copy link

ghost commented Apr 5, 2017

[edit]
I'm receiving e-mails on updates of this repository. I'm finding it interesting! I'm fairly new to GitHub. I'm editing dumb questions I should already know... If you don't want this kind of talk in chat I can stop my questions. Your work looks fabulous! Carry on! <3 Doom

@selliott512
Copy link
Author

kevbarnard82, thanks for the kind feedback. I appreciate your enthusiasm, but I'm don't have any connection to OMGIFOL other than this one pull request, so I can't speak for that project. But if you have any questions about this change that I did I'm happy to answer them.

@devinacker
Copy link
Owner

Looks good :) I can see about merging it sometime soon since I'm doing some work on the project lately anyway.

One additional idea: possibly using the thing categories in omg.thinginfo to color-code the markers similarly to e.g. Doom Builder. The actual thing type values could still be used to add some variation in brightness/saturation or something like that.

@selliott512
Copy link
Author

That might be nice, but I'm not sure what the colors should be for each category. There are cases where items in a category have distinct colors, like keys. I'll think about it more.

@selliott512
Copy link
Author

I thought I'd let you know that I'm working on a separate tool that is based on drawmaps.py. It will have a lot of command line options to configure how the images are produced. More details to come soon. So feel free to merge this or not as you see fit for demo purposes, but eventually there will be a tool that has the thing functionality in this pull request.

@selliott512
Copy link
Author

I won't keep posting here since it's not the right place, but I thought I'd follow up on my previous comment. I finished the tool I mentioned in my last comment. It's here. I've also created a gitub page for it. Anyway, thanks for your work on Omgifol. It's quite helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants