diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml index dfcadfdb6..554f8e5a1 100644 --- a/.github/workflows/npm_publish.yml +++ b/.github/workflows/npm_publish.yml @@ -3,6 +3,7 @@ on: types: [released] jobs: publish: + environment: release runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/post_check_svgs_comment.yml b/.github/workflows/post_check_svgs_comment.yml index e7c9c32e0..cce4eba31 100644 --- a/.github/workflows/post_check_svgs_comment.yml +++ b/.github/workflows/post_check_svgs_comment.yml @@ -53,7 +53,7 @@ jobs: - name: Comment on the PR about the result - SVG Error uses: jungwinter/comment@v1 # let us comment on a specific PR - if: success() && (steps.err_message_reader.outputs.content != '0' || steps.err_message_reader.outputs.content != '1') + if: success() && (steps.err_message_reader.outputs.content != '0' && steps.err_message_reader.outputs.content != '1') env: MESSAGE: | Hi! diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 356797508..153cc06de 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,6 +13,7 @@ First of all, thanks for taking the time to contribute! This project can only gr
devicon.json
+ Devicon is living by it's contributors and maintainers. Everyone can and is asked to contribute to this project. + You don't have to be in a team to contribute! +
+
+ The branches master
and develop
are protected branches and only members
+ with corresponding permissions (see teams below) are able to push changes to them.
+ Additional branches must follow the pattern username/feature/description
.
+ The /feature/
indicates that a change is made to existing code (regardless
+ if it's a fix, refactor or actual feature). The naming convention is based on the gitflow-workflow.
+
For organisational purposes we introduced teams with permissions and responsibilities:
+Write
access to the repository (allowing them to create own branches)
+ and are allowed to push changes to the develop
branch (pull request and status checks required).
+ Maintainer
permission
+ to the repository.
+ Members of this team are allowed to publish a new release (push master
branch after pull
+ request and status checks).
+
+ Wanna join the team? Please open a public discussion where
+ you introduce yourself.
+ New member requests have to be approved by all active members of the team Maintainer. Every member
+ of this team has a veto permission to reject a new member.
+
To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.
diff --git a/README.md b/README.md index f9eaf40e8..160d27b9e 100644 --- a/README.md +++ b/README.md @@ -151,7 +151,7 @@ Add css rules in your stylesheet- We are happy for every contribution. Please have a look at our contribution guidelines + We are happy for every contribution. Please have a look at our contribution guidelines to see how you can contribute to this project.
diff --git a/package.json b/package.json index 8ee977960..bfde6f698 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.10.0", + "version": "2.10.1", "description": "Programming related icons collection", "main": "devicon.min.css", "scripts": {