bugfix: card collections should bubble up after creation

Author: rohit-singh-bisht

search/src/components/BookmarkPopover.tsx

@@ -24,6 +24,7 @@ export interface BookmarkPopoverProps {
   totalCollectionPages: number;
   setLoginModal: Setter<boolean>;
   bookmarks: CardBookmarksDTO[];
+  setCardCollections: Setter<CardCollectionDTO[]>;
 }
 
 const BookmarkPopover = (props: BookmarkPopoverProps) => {
@@ -138,17 +139,17 @@ const BookmarkPopover = (props: BookmarkPopoverProps) => {
               });
             });
 
-            setLocalCardCollections(() => {
-              const deDupedPrev = data.collections.filter((collection) => {
-                return (
-                  collectionsToAdd.find(
-                    (collectionToAdd) => collectionToAdd.id == collection.id,
-                  ) == undefined
-                );
-              });
-
-              return [...collectionsToAdd, ...deDupedPrev];
+            const deDupedPrev = data.collections.filter((collection) => {
+              return (
+                collectionsToAdd.find(
+                  (collectionToAdd) => collectionToAdd.id == collection.id,
+                ) == undefined
+              );
             });
+
+            const updatedCollections = [...collectionsToAdd, ...deDupedPrev];
+            setLocalCardCollections(updatedCollections);
+            props.setCardCollections(updatedCollections);
           }
         });
       }

search/src/components/ResultsPage.tsx

@@ -175,6 +175,7 @@ const ResultsPage = (props: ResultsPageProps) => {
                   setOnDelete={setOnDelete}
                   setShowConfirmModal={setShowConfirmDeleteModal}
                   showExpand={clientSideRequestFinished()}
+                  setCardCollections={setCardCollections}
                 />
               </div>
             )}

search/src/components/ScoreCard.tsx

@@ -41,6 +41,7 @@ export interface ScoreCardProps {
   initialExpanded?: boolean;
   bookmarks: CardBookmarksDTO[];
   showExpand?: boolean;
+  setCardCollections: Setter<CardCollectionDTO[]>;
 }
 
 const ScoreCard = (props: ScoreCardProps) => {
@@ -236,6 +237,7 @@ const ScoreCard = (props: ScoreCardProps) => {
               bookmarks={props.bookmarks.filter(
                 (bookmark) => bookmark.card_uuid === props.card.id,
               )}
+              setCardCollections={props.setCardCollections}
             />
           </div>
           <div class="flex w-full items-start">

search/src/components/ScoreCardArray.tsx

@@ -1,11 +1,16 @@
+import type { Setter } from "solid-js";
 import { Show, createSignal } from "solid-js";
-import type { CardMetadataWithVotes } from "../../utils/apiTypes";
+import type {
+  CardMetadataWithVotes,
+  CardCollectionDTO,
+} from "../../utils/apiTypes";
 import type { ScoreCardProps } from "./ScoreCard";
 import { FiChevronLeft, FiChevronRight } from "solid-icons/fi";
 import ScoreCard from "./ScoreCard";
 
 export type ScoreCardAraryProps = Omit<ScoreCardProps, "card"> & {
   cards: CardMetadataWithVotes[];
+  setCardCollections: Setter<CardCollectionDTO[]>;
 };
 
 export const ScoreCardArray = (props: ScoreCardAraryProps) => {