Skip to content

Commit 34df2fe

Browse files
thepetkthepetk
authored
Replace nodejs icon link with devfile-stack-icons link (#226)
* Add only default tags in index component (#9) Signed-off-by: thepetk <[email protected]> * Update test cases Signed-off-by: thepetk <[email protected]> * Fix test cases typo Signed-off-by: thepetk <[email protected]> * Fix tags in index_extra.json Signed-off-by: thepetk <[email protected]> * Finalize test cases fixes Signed-off-by: thepetk <[email protected]> * Replace nodejs icons Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
1 parent 9445a83 commit 34df2fe

File tree

18 files changed

+35
-35
lines changed

18 files changed

+35
-35
lines changed

‎index/generator/library/library_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ func TestValidateIndexComponent(t *testing.T) {
184184
"Case 8: check for missing arch",
185185
schema.Schema{
186186
Name: "nodejs",
187-
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
187+
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
188188
Git: &schema.Git{
189189
Remotes: map[string]string{
190190
"origin": "https://github.com/redhat-developer/devfile-sample",
@@ -200,7 +200,7 @@ func TestValidateIndexComponent(t *testing.T) {
200200
"Case 9: check for missing provider",
201201
schema.Schema{
202202
Name: "nodejs",
203-
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
203+
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
204204
Versions: []schema.Version{
205205
{
206206
Version: "1.0.0",
@@ -226,7 +226,7 @@ func TestValidateIndexComponent(t *testing.T) {
226226
"Case 10: check for missing supportUrl",
227227
schema.Schema{
228228
Name: "nodejs",
229-
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
229+
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
230230
Versions: []schema.Version{
231231
{
232232
Version: "1.0.0",
@@ -361,7 +361,7 @@ func TestValidateIndexComponent(t *testing.T) {
361361
"Case 16: test happy path for for sample component with new struct",
362362
schema.Schema{
363363
Name: "nodejs",
364-
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
364+
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
365365
Versions: []schema.Version{
366366
{
367367
Version: "1.0.0",

‎index/generator/tests/registry/extraDevfileEntries.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ samples:
33
- name: nodejs-basic
44
displayName: Basic NodeJS
55
description: A simple Hello World application
6-
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
6+
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
77
tags: ["NodeJS", "Express"]
88
projectType: nodejs
99
language: nodejs

‎index/generator/tests/registry/index_extra.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"NodeJS",
99
"Express"
1010
],
11-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
11+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
1212
"projectType": "nodejs",
1313
"language": "nodejs",
1414
"versions": [

‎index/generator/tests/registry/index_main.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@
324324
},
325325
{
326326
"name": "nodejs",
327-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
327+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
328328
"displayName": "NodeJS Runtime",
329329
"description": "Stack with NodeJS 12",
330330
"type": "stack",
@@ -337,7 +337,7 @@
337337
"schemaVersion": "2.2.0",
338338
"default": true,
339339
"description": "Stack with NodeJS 12",
340-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
340+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
341341
"tags": ["NodeJS", "Express", "ubi8"],
342342
"links": {
343343
"self": "devfile-catalog/nodejs:1.0.0"
@@ -424,7 +424,7 @@
424424
"description": "A simple Hello World application",
425425
"type": "sample",
426426
"tags": ["NodeJS", "Express"],
427-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
427+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
428428
"projectType": "nodejs",
429429
"language": "nodejs",
430430
"versions": [

‎index/generator/tests/registry/index_registry.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@
325325
{
326326
"name": "nodejs",
327327
"displayName": "NodeJS Runtime",
328-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
328+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
329329
"description": "Stack with NodeJS 12",
330330
"type": "stack",
331331
"tags": ["NodeJS", "Express", "ubi8"],
@@ -337,7 +337,7 @@
337337
"schemaVersion": "2.2.0",
338338
"default": true,
339339
"description": "Stack with NodeJS 12",
340-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
340+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
341341
"tags": ["NodeJS", "Express", "ubi8"],
342342
"links": {
343343
"self": "devfile-catalog/nodejs:1.0.0"

‎index/generator/tests/registry/samples/nodejs-basic/1.0.0/devfile.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
schemaVersion: 2.0.0
22
metadata:
33
name: nodejs
4-
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
4+
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
55
version: 1.0.1
66
displayName: Node.js Runtime
77
description: Stack with Node.js 14

‎index/generator/tests/registry/samples/nodejs-basic/1.0.1/devfile.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
schemaVersion: 2.2.0
22
metadata:
33
name: nodejs
4-
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
4+
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
55
version: 1.0.1
66
displayName: Node.js Runtime
77
description: Stack with Node.js 14

‎index/generator/tests/registry/stacks/nodejs/devfile.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
schemaVersion: 2.2.0
22
metadata:
33
name: nodejs
4-
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
4+
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
55
version: 1.0.0
66
displayName: NodeJS Runtime
77
description: Stack with NodeJS 12

‎index/server/pkg/util/index.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
"version": "1.0.0",
226226
"displayName": "NodeJS Runtime",
227227
"description": "Stack with NodeJS 12",
228-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
228+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
229229
"type": "stack",
230230
"tags": [
231231
"NodeJS",
@@ -297,7 +297,7 @@
297297
"version": "1.0.1",
298298
"displayName": "Basic NodeJS",
299299
"description": "A simple Hello World application",
300-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
300+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
301301
"type": "sample",
302302
"projectType": "nodejs",
303303
"language": "nodejs"

‎index/server/registry-REST-API.adoc‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,7 +1198,7 @@ curl http://devfile-registry.192.168.1.1.nip.io/v2index/sample
11981198
"NodeJS",
11991199
"Express"
12001200
],
1201-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
1201+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
12021202
"projectType": "nodejs",
12031203
"language": "nodejs",
12041204
"versions": [
@@ -1565,7 +1565,7 @@ curl http://devfile-registry.192.168.1.1.nip.io/v2index/all
15651565
"NodeJS",
15661566
"Express"
15671567
],
1568-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
1568+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
15691569
"projectType": "nodejs",
15701570
"language": "nodejs",
15711571
"versions": [
@@ -1776,7 +1776,7 @@ curl http://devfile-registry.192.168.1.1.nip.io/v2index/sample?minSchemaVersion=
17761776
"NodeJS",
17771777
"Express"
17781778
],
1779-
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
1779+
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
17801780
"projectType": "nodejs",
17811781
"language": "nodejs",
17821782
"versions": [
@@ -1953,7 +1953,7 @@ metadata:
19531953
version: 1.0.1
19541954
displayName: Node.js Runtime
19551955
description: Stack with Node.js 14
1956-
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
1956+
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
19571957
tags: ['NodeJS', 'Express', 'ubi8']
19581958
projectType: 'nodejs'
19591959
language: 'javascript'

0 commit comments

Comments
 (0)