Skip to content

Commit 1540654

Browse files
build args & env vars adjusted.
Signed-off-by: Michael Valdron <[email protected]>
1 parent d0fd2a4 commit 1540654

File tree

3 files changed

+15
-21
lines changed

3 files changed

+15
-21
lines changed

.github/workflows/pushimage-next.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ on:
2323
jobs:
2424
registryViewerBuild:
2525
runs-on: ubuntu-latest
26-
env:
27-
NEXT_PUBLIC_ANALYTICS_WRITE_KEY: ${{ secrets.NEXT_PUBLIC_ANALYTICS_WRITE_KEY }}
2826
steps:
2927
- name: Check out devfile web source code
3028
uses: actions/checkout@v3

Dockerfile

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,41 +33,32 @@ RUN \
3333

3434
# Rebuild the source code only when needed
3535
FROM node:16-alpine AS builder
36-
ARG NEXT_PUBLIC_BASE_PATH=/
37-
ARG NEXT_PUBLIC_DEVFILE_REGISTRIES=
38-
ARG NEXT_PUBLIC_ANALYTICS_WRITE_KEY=
36+
ARG BASE_PATH=
3937
ARG PROJECT_NAME
4038
# Add bash to support local scripts
4139
RUN apk add --no-cache bash
4240
WORKDIR /app
4341
COPY --from=deps /app/node_modules ./node_modules
4442
COPY . .
4543

46-
ENV NEXT_PUBLIC_BASE_PATH ${NEXT_PUBLIC_BASE_PATH}
47-
ENV NEXT_PUBLIC_DEVFILE_REGISTRIES ${NEXT_PUBLIC_DEVFILE_REGISTRIES}
48-
ENV NEXT_PUBLIC_ANALYTICS_WRITE_KEY ${NEXT_PUBLIC_ANALYTICS_WRITE_KEY}
49-
5044
# Next.js collects completely anonymous telemetry data about general usage.
5145
# Learn more here: https://nextjs.org/telemetry
5246
# Uncomment the following line in case you want to disable telemetry during the build.
5347
ENV NEXT_TELEMETRY_DISABLED 1
5448

55-
RUN yarn nx run ${PROJECT_NAME}:postexport --skip-nx-cache
49+
RUN NEXT_PUBLIC_BASE_PATH=${BASE_PATH} yarn nx run ${PROJECT_NAME}:postexport --skip-nx-cache
5650

5751
# Production image, copy all the files and run next
5852
FROM node:16-alpine AS runner
59-
ARG NEXT_PUBLIC_BASE_PATH=/
60-
ARG NEXT_PUBLIC_DEVFILE_REGISTRIES=
61-
ARG NEXT_PUBLIC_ANALYTICS_WRITE_KEY=
53+
ARG BASE_PATH=
6254
ARG PROJECT_NAME
6355
WORKDIR /app
6456

6557
ENV NODE_ENV production
66-
ENV NEXT_PUBLIC_BASE_PATH ${NEXT_PUBLIC_BASE_PATH}
67-
ENV NEXT_PUBLIC_DEVFILE_REGISTRIES ${NEXT_PUBLIC_DEVFILE_REGISTRIES}
68-
ENV NEXT_PUBLIC_ANALYTICS_WRITE_KEY ${NEXT_PUBLIC_ANALYTICS_WRITE_KEY}
6958
# Uncomment the following line in case you want to disable telemetry during runtime.
7059
ENV NEXT_TELEMETRY_DISABLED 1
60+
# Sets base path of registry viewer
61+
ENV NEXT_PUBLIC_BASE_PATH=${BASE_PATH}
7162

7263
RUN addgroup --system --gid 1001 nodejs
7364
RUN adduser --system --uid 1001 nextjs

scripts/build_viewer.sh

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,13 @@
1414

1515
#!/usr/bin/env bash
1616

17-
docker build -t registry-viewer . \
18-
--build-arg PROJECT_NAME=registry-viewer \
19-
--build-arg NEXT_PUBLIC_BASE_PATH=/viewer \
20-
--build-arg NEXT_PUBLIC_DEVFILE_REGISTRIES="${NEXT_PUBLIC_DEVFILE_REGISTRIES:-""}" \
21-
--build-arg NEXT_PUBLIC_ANALYTICS_WRITE_KEY=${NEXT_PUBLIC_ANALYTICS_WRITE_KEY:-""}
17+
# Environment Variables:
18+
#
19+
# NEXT_PUBLIC_DEVFILE_REGISTRIES - JSON array of objects which define a registry server source,
20+
# default: '[{"name": "Community", "link": "https://registry.stage.devfile.io"}]'
21+
#
22+
# NEXT_PUBLIC_ANALYTICS_WRITE_KEY - Analytics write key for telemetry, default: blank
23+
#
24+
25+
docker build -t registry-viewer . --build-arg PROJECT_NAME=registry-viewer \
26+
--build-arg BASE_PATH=/viewer

0 commit comments

Comments
 (0)