Skip to content

Cleanup printcolumns #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Cleanup printcolumns #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d420a66
Remove ideUrl from DevWorkspace printcolumns; reuse message instead
amisevsk Feb 1, 2021
2db8dd9
Regenerate CRDs after changing printcolumns for ideUrl
amisevsk Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions crds/workspace.devfile.io_devworkspaces.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4088,13 +4088,9 @@ spec:
name: Phase
type: string
- JSONPath: .status.message
description: Additional information about workspace state
description: Additional information about the workspace
name: Info
type: string
- JSONPath: .status.ideUrl
description: Url endpoint for accessing workspace
name: URL
type: string
name: v1alpha2
schema:
openAPIV3Schema:
Expand Down
6 changes: 1 addition & 5 deletions crds/workspace.devfile.io_devworkspaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4085,14 +4085,10 @@ spec:
jsonPath: .status.phase
name: Phase
type: string
- description: Additional information about workspace state
- description: Additional information about the workspace
jsonPath: .status.message
name: Info
type: string
- description: Url endpoint for accessing workspace
jsonPath: .status.ideUrl
name: URL
type: string
name: v1alpha2
schema:
openAPIV3Schema:
Expand Down
3 changes: 1 addition & 2 deletions pkg/apis/workspaces/v1alpha2/devworkspace_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ const (
// +kubebuilder:resource:path=devworkspaces,scope=Namespaced,shortName=dw
// +kubebuilder:printcolumn:name="Workspace ID",type="string",JSONPath=".status.workspaceId",description="The workspace's unique id"
// +kubebuilder:printcolumn:name="Phase",type="string",JSONPath=".status.phase",description="The current workspace startup phase"
// +kubebuilder:printcolumn:name="Info",type="string",JSONPath=".status.message",description="Additional information about workspace state"
// +kubebuilder:printcolumn:name="URL",type="string",JSONPath=".status.ideUrl",description="Url endpoint for accessing workspace"
// +kubebuilder:printcolumn:name="Info",type="string",JSONPath=".status.message",description="Additional information about the workspace"
// +devfile:jsonschema:generate
// +kubebuilder:storageversion
type DevWorkspace struct {
Expand Down