Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support headers #133

Merged
merged 2 commits into from
Dec 24, 2020
Merged

Support headers #133

merged 2 commits into from
Dec 24, 2020

Conversation

Lonelind
Copy link
Contributor

Hi!

This PR adds support for headers, partly resolving #57.

Test cases with arrays also added.

@raveclassic
Copy link
Contributor

Hi @Lonelind, thank you for the PR!

Could you please clarify what you mean by "partially resolving #57"?

@raveclassic raveclassic self-requested a review December 24, 2020 17:15
@raveclassic
Copy link
Contributor

@Lonelind Please open a satellite issue tracking swagger2.0 spec if you are not going to support it in this PR (I wouldn't suggest to do it).

@Lonelind
Copy link
Contributor Author

I didn't add formData there but I guess it'd be about the same. Currently, this only helps with headers because it's really needed on my project due to the API design.

@raveclassic
Copy link
Contributor

@Lonelind Please open issues to track missing things :)

@Lonelind
Copy link
Contributor Author

Swagger 2.0 is supported

@raveclassic
Copy link
Contributor

@Lonelind Sorry, didn't notice that! Thanks, LGTM. But please open an issue for the missing parts (FormData etc.)

@raveclassic raveclassic merged commit 1b0c947 into devexperts:master Dec 24, 2020
@Lonelind
Copy link
Contributor Author

I'd rather add a notice to #57 that headers are done and resolve #39 because this PR just adds one thing of many from the list.

raveclassic pushed a commit that referenced this pull request Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants