Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max retries does not seem to take effect #162

Open
ion-elgreco opened this issue Jan 21, 2025 · 2 comments
Open

Max retries does not seem to take effect #162

ion-elgreco opened this issue Jan 21, 2025 · 2 comments

Comments

@ion-elgreco
Copy link

I have set up an Azure Store with the below config, it should retry 10 times, but this doesn't seem to happen. The reqwest shows only 0 retries?

AzureStore(
            container=container,
            timeout="60s",
            retry_config={
                "max_retries": 10,
                "retry_timeout": timedelta(seconds=5),
                "backoff": {
                    "init_backoff": timedelta(seconds=5),
                    "max_backoff": timedelta(seconds=30),
                    "base": 1.2,
                },
            },
            **self.credentials.model_dump(),
        )
pyo3_object_store.GenericError: Generic {
    store: "MicrosoftAzure",
    source: Reqwest {
        retries: 0,
        max_retries: 10,
        elapsed: 16.221359064s,
        retry_timeout: 5s,
        source: reqwest::Error {
            kind: Request,
            url: "<redacted>manylinux2014_x86_64.whl",
            source: hyper_util::client::legacy::Error(
                Connect,
                TimedOut,
            ),
        },
    },
}
@kylebarron
Copy link
Member

Hmm... I'm not sure exactly what to make of this. It seems like the configuration is correctly getting passed through... that error does say that Reqwest has max_retries: 10. Is there a difference between retries and max_retries then?

@kylebarron
Copy link
Member

Perhaps this is similar to #159 (comment), where there's some collision between top-level and client options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants