Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all labels for border tiles are downloaded #176

Open
janpisl opened this issue Aug 15, 2020 · 4 comments
Open

Not all labels for border tiles are downloaded #176

janpisl opened this issue Aug 15, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@janpisl
Copy link

janpisl commented Aug 15, 2020

Perhaps it's best to explain my issue with a simple example:

  1. I set the bounding_box in config.json to [0,0, 100,100].
  2. I download labels within the bounding box
  3. I download tiles of size 20*20. One of the downloaded tiles is "Tile X" with coordinates [90,90, 110,110].
  4. In tile X, my model detects an "object O" at coords [105, 105, 106, 106].
  5. This object is however not in labels because it is outside of the bounding box set in config.json. So it seems like a "false positive" when actually the detection is correct.

Is this known/desired?

I imagine a functionality could be added that would check coordinates of tiles and then download all labels within the tiles.

@drewbo
Copy link
Contributor

drewbo commented Aug 17, 2020

Thanks for the write-up and identification. I think the current behavior is not desired and the ideal functionality would be to use all labels within the downloaded tiles

@drewbo drewbo added the bug Something isn't working label Aug 17, 2020
@janpisl
Copy link
Author

janpisl commented Aug 18, 2020

Sure! Let me know if I can help to fix this, I'd be happy to contribute.

@drewbo
Copy link
Contributor

drewbo commented Aug 19, 2020

That would be great. I'm prepping a 0.9.0 release now (all of @martham93's recent work) and it will be easiest to branch off that shortly

@janpisl
Copy link
Author

janpisl commented Sep 5, 2020

Hi, sorry I am currently swamped with other work so I am not sure when I find time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants