Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CLI installation via pip #33

Closed
gadomski opened this issue Oct 9, 2024 · 3 comments · Fixed by #38
Closed

Enable CLI installation via pip #33

gadomski opened this issue Oct 9, 2024 · 3 comments · Fixed by #38
Assignees
Milestone

Comments

@gadomski
Copy link
Collaborator

gadomski commented Oct 9, 2024

Over at stac-rs I used a separate Python package (https://pypi.org/project/stacrs/ and https://pypi.org/project/stacrs-cli/) and I think we should do the same here, since the CLI is a separate crate. So that'd be cql2-cli on PyPI.

@kylebarron
Copy link
Member

What's the rationale for having the CLI be separate? It seems like it would be easy enough to ship along with the main Python library?

@gadomski
Copy link
Collaborator Author

gadomski commented Oct 9, 2024

What's the rationale for having the CLI be separate? It seems like it would be easy enough to ship along with the main Python library?

I think it comes from my aversion to click being pulled in to Python libs when you don't want it — in the same manner, if we don't need clap in our Python package let's not include it. However, the downside is that we take up two packages instead of one, and folks might be surprised when the pip install cql2 doesn't come with a CLI.

Really happy w/ either, I don't have a strong preference.

@kylebarron
Copy link
Member

I assume that clap is relatively small. I doubt it increases the bundle size of the wheels much at all. I figure unless you have big dependencies that you need to keep separate, the simplicity of having a single wheel building process is preferred.

@gadomski gadomski added this to the v0.2 milestone Oct 10, 2024
@gadomski gadomski self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants