-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing error message when not closing an element #56
Comments
This is something we gave up when moving from using the browser's HTML parser to a custom parser in 2.0. The tradeoffs of being able to run directly in Node.js and reducing the library size were good, but we have heard from a few people that some of the niceties of HTML like this would be pleasant to have back. I'm not sure how feasible it is to implement void elements, since its a whitelist. Perhaps we could move validation into something like an editor plugin? |
I just realized that i don't understand why a small library size would be a goal of this library My understanding is that for most libraries, the size of the library is a necessary cost to be paid for the functionnality it offers However, for Under these circumstances, i see using the |
I understand that for some use-cases, the library size is less important. However, there are potential performance reasons to use htm without transpiling in production - including some interesting tradeoffs for JS parsing time. At 400-500 bytes, those tradeoffs are often worthwhile. A 10kb implementation with pretty warnings and english messages would likely invalidate that. |
Just an addendum: I think it would be both possible and reasonable to add extended parser error messages to |
Example code:
Being used to write HTML and not having to close every element (especially inputs), i can write this sort of code
With
htm
, i get the following error:SyntaxError: missing ) after argument list
This errors seems non-intuitive to me
The text was updated successfully, but these errors were encountered: