Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Request ] Support remix-auth@v4 and RR7 #81

Closed
incadenza opened this issue Dec 9, 2024 · 4 comments
Closed

[ Request ] Support remix-auth@v4 and RR7 #81

incadenza opened this issue Dec 9, 2024 · 4 comments

Comments

@incadenza
Copy link

Hey, there. Huge fan of your work - I've been using your remix auth tools for as along as I've worked with Remix. Much gratititude.

Is there any small direction you can nudge me in to be of assistance here? I noticed this library is behind the 2.0 of the main remix-auth.

Again, many thanks. I want to help

@dev-xo
Copy link
Owner

dev-xo commented Dec 9, 2024

Hello @incadenza!

First of all, thanks for the gratitude, also happy to know remix-auth-totp has been useful to you.

To be honest, I'm a bit busy lately, and neither of the latest updates on the library were handled by me. I know @sergiodxa has got remix-auth to v4, supporting RR7, and I had in mind to look into it sooner or later (although not sure when).

I wonder if he could share some little insights that may help us give support to RR7, allowing the library to continue being useful for others.

Also, wonder if @mw10013 wants to or would be able to share some thoughts on this too.

In any case, thanks for the great words, and hopefully, between us all, we could give RR7 support and keep the library useful for us and for others!

@sergiodxa
Copy link

The main change for strategies is regarding to sessions/cookies, since there's no sessionStorage anymore, you will either need to ask the sessionStorage object as an option of the strategy, or you will have to change to a cookie or use something else.

In the OAuth2Strategy and GitHubStrategy I'm using @mjackson/headers to work with cookies directly instead of using the app session storage.

Then the this.success and this.failure functions are removed, in case of success just return the result of this.verify, in case of failure throw an error yourself.

@CyrusVorwald
Copy link
Contributor

I submitted a PR to be compatible with remix auth v4 by using cookies directly as per @sergiodxa's helpful response. This removed a couple tests that were checking context. See #82

@dev-xo
Copy link
Owner

dev-xo commented Dec 19, 2024

Thanks @CyrusVorwald! Will review your PR and continue the discussion there. Also, thanks to @sergiodxa for the insights and the response!

@dev-xo dev-xo changed the title Love to help upgrading version [ Request ] Support remix-auth@v4 and RR7 Dec 19, 2024
@dev-xo dev-xo closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants