-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Request ] Support remix-auth@v4
and RR7
#81
Comments
Hello @incadenza! First of all, thanks for the gratitude, also happy to know To be honest, I'm a bit busy lately, and neither of the latest updates on the library were handled by me. I know @sergiodxa has got I wonder if he could share some little insights that may help us give support to RR7, allowing the library to continue being useful for others. Also, wonder if @mw10013 wants to or would be able to share some thoughts on this too. In any case, thanks for the great words, and hopefully, between us all, we could give RR7 support and keep the library useful for us and for others! |
The main change for strategies is regarding to sessions/cookies, since there's no In the OAuth2Strategy and GitHubStrategy I'm using Then the |
I submitted a PR to be compatible with remix auth v4 by using cookies directly as per @sergiodxa's helpful response. This removed a couple tests that were checking context. See #82 |
Thanks @CyrusVorwald! Will review your PR and continue the discussion there. Also, thanks to @sergiodxa for the insights and the response! |
remix-auth@v4
and RR7
Hey, there. Huge fan of your work - I've been using your remix auth tools for as along as I've worked with Remix. Much gratititude.
Is there any small direction you can nudge me in to be of assistance here? I noticed this library is behind the 2.0 of the main remix-auth.
Again, many thanks. I want to help
The text was updated successfully, but these errors were encountered: