-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Record the user that initiated a notification event #221
Comments
1st scenario: Other users comment in my Idea and my notifications are on:
2nd scenario: Other users comment in my Idea and my notifications are off:
3rd scenario: I comment in my own Idea:
Important to validate
|
@tiagopazhs @oriyomibadmus do either of you have availability to discuss this on Tuesday after 6:30pm Central time? |
Hey @dbradham 6:30pm CT looks good ? |
Sorry for the latest answear, we can schedulle another time ? |
After discussion, we have determined scenario 2 & 3 are outside the acceptance criteria for this ticket. The expected settings are for notifications to be on. @tiagopazhs has asked the IdeaSpace team for feedback on the idea-specific notification settings. |
@oriyomibadmus as we discussed with @dbradham the field Comment.author is not used anymore. Please remove that. |
@oriyomibadmus and @dbradham, We can have a discussion here why we weren't able to reproduce the error using the admin pannel ? |
This behavior is unstable due to the hook on line 6 of this screenshot @tiagopazhs
|
@oriyomibadmus The It seems that this was working differently for Vivien 11 days ago. I believe the issue is because my user has no username- When I updated my username in the staging database, I got the expected result: @chungthuang please let us know if the acceptance criteria is met here. It seems to work as expected from my tests. |
@chungthuang I am moving this to Done per our discussion in the team sync call |
Summary
As the owner of an idea card, I'd like to know who commented on my ideas.
Describe the solution you'd like
Add a new field in the event collection to record the user that triggered the event. We need to update the lifecycle method that generates the event to send the user information.
Acceptance criteria
Integration test should assert that when user A comments on an idea card owned by user B, user B is able to see user A commented on the idea. For privacy concerns, user B should only see public information about user A.
The text was updated successfully, but these errors were encountered: