From 26da3e56b20f41e670d5ae4483e940e1305419c3 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Tue, 15 Sep 2026 00:33:08 -0400 Subject: [PATCH] Remove the flaky-test-to-GitHub-issues reporting job from `end2end-test.yml`. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes the `report-to-issues` job (`Report to GitHub`) from `.github/workflows/end2end-test.yml`. `report-to-issues` checks out `trunk` (`ref: trunk`) and then runs `npm run build:packages` before invoking `./packages/report-flaky-tests` — it always builds and runs live current trunk's copy of the action, never this frozen branch's own. Trunk has since removed the `build:packages` script from `package.json` as part of migrating `report-flaky-tests` to run directly from its TypeScript sources via Node 24's native type stripping, with no build step (`using: 'node24'`, `main: 'src/index.ts'`), so the job's build step now fails with `npm error Missing script: "build:packages"` whenever it reaches that point. Confirmed live and current on this branch, not just inferred: PR #346's own `Report to GitHub` job failed on run 34801278771/job 103934457687 with exactly this error, after `npm ci`/`postinstall` completed against trunk's current `package.json`. This is a structural failure, not a one-time regression: because the job always tracks a moving target (trunk) rather than the branch's own pinned copy, it will keep breaking as trunk's tooling around this action continues to evolve, regardless of anything in this branch. Retrofitting trunk's current version was considered and rejected — trunk's rewrite also drops GitHub-issue filing for flaky tests in favor of PR-comment-only reporting, a product-policy change out of scope for a frozen, security-maintenance-only branch. This mirrors the same fix already applied as the `disable-flaky-test-issue-reporting` layer on `wp/6.3`-`wp/6.8`. Removing the job only drops an automated notification; no test-correctness signal depends on it. `packages/report-flaky-tests` is left in place, now unused by any workflow on this branch — removing it is optional cleanup out of scope here. # Conflicts: # .github/workflows/end2end-test.yml --- .github/workflows/end2end-test.yml | 42 ------------------------------ 1 file changed, 42 deletions(-) diff --git a/.github/workflows/end2end-test.yml b/.github/workflows/end2end-test.yml index 91a671ec5ecd2e..3601f55ffb38f1 100644 --- a/.github/workflows/end2end-test.yml +++ b/.github/workflows/end2end-test.yml @@ -117,45 +117,3 @@ jobs: name: flaky-tests-report path: flaky-tests if-no-files-found: ignore - - report-to-issues: - name: Report to GitHub - needs: [e2e-puppeteer, e2e-playwright] - if: ${{ always() }} - runs-on: ubuntu-latest - steps: - # Checkout defaults to using the branch which triggered the event, which - # isn't necessarily `trunk` (e.g. in the case of a merge). - - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - with: - ref: trunk - - - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 - id: download_artifact - # Don't fail the job if there isn't any flaky tests report. - continue-on-error: true - with: - name: flaky-tests-report - path: flaky-tests - - - name: Use desired version of NodeJS - if: ${{ steps.download_artifact.outcome == 'success' }} - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 - with: - node-version-file: '.nvmrc' - cache: npm - - - name: Npm install and build - if: ${{ steps.download_artifact.outcome == 'success' }} - # TODO: We don't have to build the entire project, just the action itself. - run: | - npm ci - npm run build:packages - - - name: Report flaky tests - if: ${{ steps.download_artifact.outcome == 'success' }} - uses: ./packages/report-flaky-tests - with: - repo-token: '${{ secrets.GITHUB_TOKEN }}' - label: '[Type] Flaky Test' - artifact-path: flaky-tests