Apply Bobby Smiles' suggestions

Author: derselbst

rsp_hle/alist.c

@@ -1032,7 +1032,7 @@ void alist_iirf(
 }
 
 /* Perform a clamped gain, then attenuate it back by an amount */
-void alist_overload(struct hle_t* hle, uint16_t dmem, int16_t count, int16_t gain, int16_t attenuation)
+void alist_overload(struct hle_t* hle, uint16_t dmem, int16_t count, int16_t gain, uint16_t attenuation)
 {
     int16_t accu;
     int16_t * sample = (int16_t*)(hle->alist_buffer + dmem);
@@ -1043,4 +1043,4 @@ void alist_overload(struct hle_t* hle, uint16_t dmem, int16_t count, int16_t gai
         sample++;
         count --;
     }
-}
+}

rsp_hle/alist.h

@@ -159,7 +159,7 @@ void alist_overload(
         uint16_t dmem,
         int16_t count,
         int16_t gain,
-        int16_t attenuation);
+        uint16_t attenuation);
 
 /*
  * Audio flags

rsp_hle/alist_naudio.c

@@ -267,8 +267,8 @@ static void OVERLOAD(struct hle_t* hle, uint32_t w1, uint32_t w2)
 {
     /* Overload distortion effect for Conker's Bad Fur Day */
     uint16_t dmem = (w1 & 0xfff) + NAUDIO_MAIN;
-    int16_t gain = w2 & 0x7fff;
-    int16_t attenuation = w2 >> 16;
+    int16_t gain = (int16_t)(uint16_t)w2;
+    uint16_t attenuation = w2 >> 16;
 
     alist_overload(hle, dmem, NAUDIO_COUNT, gain, attenuation);
 }
@@ -351,15 +351,15 @@ void alist_process_naudio_dk(struct hle_t* hle)
 void alist_process_naudio_mp3(struct hle_t* hle)
 {
     static const acmd_callback_t ABI[0x10] = {
-        UNKNOWN,        ADPCM,          CLEARBUFF,      ENVMIXER,
+        OVERLOAD,       ADPCM,          CLEARBUFF,      ENVMIXER,
         LOADBUFF,       RESAMPLE,       SAVEBUFF,       MP3,
         MP3ADDY,        SETVOL,         DMEMMOVE,       LOADADPCM,
         MIXER,          INTERLEAVE,     NAUDIO_14,      SETLOOP
     };
 
     #ifdef DEBUG_INFO
     static const char * ABI_names[0x10] = {
-       "UNKNOWN",      "ADPCM",        "CLEARBUFF",    "ENVMIXER",
+       "OVERLOAD",     "ADPCM",        "CLEARBUFF",    "ENVMIXER",
        "LOADBUFF",     "RESAMPLE",     "SAVEBUFF",     "MP3",
        "MP3ADDY",      "SETVOL",       "DMEMMOVE",     "LOADADPCM",
        "MIXER",        "INTERLEAVE",   "NAUDIO_14",    "SETLOOP"
@@ -384,7 +384,7 @@ void alist_process_naudio_cbfd(struct hle_t* hle)
 
     #ifdef DEBUG_INFO
     static const char * ABI_names[0x10] = {
-       "UNKNOWN",      "ADPCM",        "CLEARBUFF",    "ENVMIXER",
+       "OVERLOAD",     "ADPCM",        "CLEARBUFF",    "ENVMIXER",
        "LOADBUFF",     "RESAMPLE",     "SAVEBUFF",     "MP3",
        "MP3ADDY",      "SETVOL",       "DMEMMOVE",     "LOADADPCM",
        "MIXER",        "INTERLEAVE",   "NAUDIO_14",    "SETLOOP"