Skip to content

Commit 4c9372a

Browse files
committed
Move away from docker e2e images, use gcr and ghcr
Signed-off-by: Derek Nola <[email protected]>
1 parent 1813c5e commit 4c9372a

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

tests/e2e/privateregistry/Vagrantfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def provision(vm, role, role_num, node_num)
3737
endpoint:
3838
- http://%{net}.100:5000
3939
rewrite:
40-
"^library/(.*)$": "docker-io-library/$1"
40+
"^library/(.*)$": "ghcr-io-library/$1"
4141
' > /etc/rancher/k3s/registries.yaml
4242
SCRIPT
4343

tests/e2e/privateregistry/privateregistry_test.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -78,32 +78,32 @@ var _ = Describe("Verify Create", Ordered, func() {
7878
Expect(err).NotTo(HaveOccurred())
7979

8080
})
81-
// Mirror the image as NODEIP:5000/docker-io-library/nginx:1.27.3, but reference it as my-registry.local/library/nginx:1.27.3 -
81+
// Mirror the image as NODEIP:5000/ghcr-io-library/nginx:1.26.2, but reference it as my-registry.local/library/nginx:1.26.2 -
8282
// the rewrite in registries.yaml's entry for my-registry.local should ensure that it is rewritten properly when pulling from
8383
// NODEIP:5000 as a mirror.
84-
It("Should pull and image from dockerhub and send it to private registry", func() {
85-
cmd := "docker pull docker.io/library/nginx:1.27.3"
84+
It("Should pull and image from ghcr and send it to private registry", func() {
85+
cmd := "docker pull ghcr.io/linuxserver/nginx:1.26.2"
8686
_, err := tc.Servers[0].RunCmdOnNode(cmd)
8787
Expect(err).NotTo(HaveOccurred(), "failed: "+cmd)
8888

8989
nodeIP, err := tc.Servers[0].FetchNodeExternalIP()
9090
Expect(err).NotTo(HaveOccurred())
9191

92-
cmd = "docker tag docker.io/library/nginx:1.27.3 " + nodeIP + ":5000/docker-io-library/nginx:1.27.3"
92+
cmd = "docker tag ghcr.io/linuxserver/nginx:1.26.2 " + nodeIP + ":5000/ghcr-io-library/nginx:1.26.2"
9393
_, err = tc.Servers[0].RunCmdOnNode(cmd)
9494
Expect(err).NotTo(HaveOccurred(), "failed: "+cmd)
9595

96-
cmd = "docker push " + nodeIP + ":5000/docker-io-library/nginx:1.27.3"
96+
cmd = "docker push " + nodeIP + ":5000/ghcr-io-library/nginx:1.26.2"
9797
_, err = tc.Servers[0].RunCmdOnNode(cmd)
9898
Expect(err).NotTo(HaveOccurred(), "failed: "+cmd)
9999

100-
cmd = "docker image remove docker.io/library/nginx:1.27.3 " + nodeIP + ":5000/docker-io-library/nginx:1.27.3"
100+
cmd = "docker image remove ghcr.io/linuxserver/nginx:1.26.2 " + nodeIP + ":5000/ghcr-io-library/nginx:1.26.2"
101101
_, err = tc.Servers[0].RunCmdOnNode(cmd)
102102
Expect(err).NotTo(HaveOccurred(), "failed: "+cmd)
103103
})
104104

105105
It("Should create and validate deployment with private registry on", func() {
106-
res, err := tc.Servers[0].RunCmdOnNode("kubectl create deployment my-webpage --image=my-registry.local/library/nginx:1.27.3")
106+
res, err := tc.Servers[0].RunCmdOnNode("kubectl create deployment my-webpage --image=my-registry.local/library/nginx:1.26.2")
107107
fmt.Println(res)
108108
Expect(err).NotTo(HaveOccurred())
109109

@@ -120,7 +120,7 @@ var _ = Describe("Verify Create", Ordered, func() {
120120
}, "60s", "5s").Should(Succeed())
121121

122122
cmd := "curl -m 5 -s -f http://" + pod.Status.PodIP
123-
Expect(tc.Servers[0].RunCmdOnNode(cmd)).To(ContainSubstring("Welcome to nginx!"))
123+
Expect(tc.Servers[0].RunCmdOnNode(cmd)).To(ContainSubstring("Welcome to our server"))
124124
})
125125

126126
})

tests/e2e/s3/Vagrantfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def provision(vm, role, role_num, node_num)
2929

3030

3131
runS3mock = <<~'SCRIPT'
32-
docker run -p 9090:9090 -p 9191:9191 -d -e initialBuckets=test-bucket -e debug=true -t adobe/s3mock
32+
docker run -p 9090:9090 -p 9191:9191 -d -e initialBuckets=test-bucket -e debug=true -t mirror.gcr.io/adobe/s3mock
3333
SCRIPT
3434

3535

tests/e2e/startup/startup_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,9 @@ var _ = Describe("Various Startup Configurations", Ordered, func() {
331331
})
332332
Context("Verify server picks up preloaded images on start", func() {
333333
It("Downloads and preloads images", func() {
334-
_, err := tc.Servers[0].RunCmdOnNode("docker pull ranchertest/mytestcontainer:latest")
334+
_, err := tc.Servers[0].RunCmdOnNode("docker pull rancher/shell:v0.1.28")
335335
Expect(err).NotTo(HaveOccurred())
336-
_, err = tc.Servers[0].RunCmdOnNode("docker save ranchertest/mytestcontainer:latest -o /tmp/mytestcontainer.tar")
336+
_, err = tc.Servers[0].RunCmdOnNode("docker save rancher/shell:v0.1.28 -o /tmp/mytestcontainer.tar")
337337
Expect(err).NotTo(HaveOccurred())
338338
_, err = tc.Servers[0].RunCmdOnNode("mkdir -p /var/lib/rancher/k3s/agent/images/")
339339
Expect(err).NotTo(HaveOccurred())
@@ -352,9 +352,9 @@ var _ = Describe("Various Startup Configurations", Ordered, func() {
352352
})
353353
It("has loaded the test container image", func() {
354354
Eventually(func() (string, error) {
355-
cmd := "k3s crictl images | grep ranchertest/mytestcontainer"
355+
cmd := "k3s crictl images | grep rancher/shell"
356356
return tc.Servers[0].RunCmdOnNode(cmd)
357-
}, "120s", "5s").Should(ContainSubstring("ranchertest/mytestcontainer"))
357+
}, "120s", "5s").Should(ContainSubstring("rancher/shell"))
358358
})
359359
It("Kills the cluster", func() {
360360
err := KillK3sCluster(tc.AllNodes())

0 commit comments

Comments
 (0)