Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept link clicks module #24

Open
wesleytodd opened this issue Apr 22, 2015 · 0 comments
Open

Intercept link clicks module #24

wesleytodd opened this issue Apr 22, 2015 · 0 comments

Comments

@wesleytodd
Copy link

https://github.com/wesleytodd/intercept-link-clicks

@nateps I figured I could knock this one out really quick. I pulled out what was in Nighthawk verbatim, then went through and added most of the stuff from here: https://github.com/derbyjs/tracks/blob/master/lib/History.js#L145

The only things I didn't add was your check for data-router-ignore and my check for the base path. I figured that our independent work can just add these kind of features after the main checks. I did that here in Nighthawk: https://github.com/wesleytodd/nighthawk/blob/intercept-clicks/lib/router.js#L135

What do you think? I tried to keep is simple, the main interface is the single function. I also moved over the unit tests from Nighthawk that covered that section. But it would probably need a bit more test coverage...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant