Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional flags: "report only", "score threshold" and "exit code" #151

Closed
bygui86 opened this issue Jan 14, 2021 · 2 comments
Closed

Additional flags: "report only", "score threshold" and "exit code" #151

bygui86 opened this issue Jan 14, 2021 · 2 comments

Comments

@bygui86
Copy link

bygui86 commented Jan 14, 2021




Is your feature request related to a problem? Please describe.
Running Popeye in my cluster as Job, if the score is not high enough (I suppose > 90), the whole run will fail because the exit code is 1.

Describe the solution you'd like
Locally and inside a CI/CD pipeline, it's good to have the popeye command failing in case of score not high enough, but as a Kubernetes Job in my opinion it does not always matter. Considering also that the score threshold is not configurable.
I suggest to add a couple of flags:

  • a (boolean) flag to set that the run is only to generate a report
    for example --report-only
  • a (numeric) flag to set the score threshold, under which the command exit with code 1 (or different than 0)
    for example --min-score-threshold/-t
  • a (numeric) flag to set the exit code no matter the score
    for example --exit-code/-e

Describe alternatives you've considered
For now I just avoid to run the job again in case of failure, so I'm able to easily export the report and analyze it.

@derailed
Copy link
Owner

derailed commented May 5, 2021

@bygui86 PR #150

@derailed derailed closed this as completed May 5, 2021
@bygui86
Copy link
Author

bygui86 commented May 5, 2021

@derailed thanks a good PR!

What about "a (numeric) flag to set the score threshold, under which the command exit with code 1 (or different than 0)
for example --min-score-threshold/-t" ?

It could be really useful in case of some "temporary compromises" in a CI/CD :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants