Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] support image list layers, find file, view file contents, integration with DIVE #585

Closed
Slach opened this issue Feb 27, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@Slach
Copy link

Slach commented Feb 27, 2020




Is your feature request related to a problem? Please describe.
Sometimes I need to view actual file content of pulled images, currently, I try to use https://github.com/wagoodman/dive for it, but it cant show me contents of files which exist in layers wagoodman/dive#224

Describe the solution you'd like
I would like plugin integration between dive and k9s but the definition of done is ability to view file content inside image

@derailed derailed added the enhancement New feature or request label Feb 28, 2020
@mycrEEpy
Copy link
Contributor

mycrEEpy commented Mar 8, 2020

Does not solve your problem but you could use the plugin function of k9s for dive:

plugin:
  dive:
    shortCut: d
    description: "Dive image"
    scopes:
      - containers
    command: dive
    background: false
    args:
      - $COL1

@derailed there seems to be a little bug with this when you have multiple containers in one pod, the $COL1 does not always select the correct row (tested with k9s 0.17.5)

@yashbhutwala
Copy link

yashbhutwala commented Apr 19, 2020

@mycrEEpy I tried your suggestion, but it didn't work for me (k9s version 0.19.2). I think this feature would be awesome!! Thanks @derailed for this utility btw, I love k9s! 😍

@mycrEEpy this is the error I see:

10:36AM ERR Plugin Args match failed error="no environment matching key \"$COL1\":\"COL1\""

@mycrEEpy
Copy link
Contributor

@yashbhutwala With k9s v0.17.7 the column reference for plugins changed from index to named columns. Above v0.17.7 it should work with:

plugin:
  dive:
    shortCut: d
    description: "Dive image"
    scopes:
      - containers
    command: dive
    background: false
    args:
      - $COL-IMAGE

@yashbhutwala
Copy link

Awesome @mycrEEpy!! that works marvelously 😃

@derailed
Copy link
Owner

@mycrEEpy Thank you so much for seeing this thru!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants