Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add smoke tests #220

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(ci): add smoke tests #220

wants to merge 7 commits into from

Conversation

nayanrajDQ
Copy link
Contributor

Closes #216

@nayanrajDQ nayanrajDQ marked this pull request as ready for review January 27, 2025 12:11
@nayanrajDQ nayanrajDQ requested a review from a team as a code owner January 27, 2025 12:11
Copy link

@maksym-shynkarenko maksym-shynkarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small comment

- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version || '20' }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value is 20 but on the line 50 we have node-version: 16. Just to make sure that we use the same node version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA: smoke tests for watcher examples
2 participants