Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest && python setup.py build fails on PyPI tarball #3

Open
eli-schwartz opened this issue Oct 25, 2019 · 1 comment
Open

pytest && python setup.py build fails on PyPI tarball #3

eli-schwartz opened this issue Oct 25, 2019 · 1 comment

Comments

@eli-schwartz
Copy link

error: package directory 'dephell_venvs/ensurepip' does not exist

The conftest for the unittests modifies the source code and removes a module which is in the packages keyword in the PyPI download tarball.

Broken in #2 commit 3892789 -- I don't quite understand what the goal is here, though. ensurepip is bundled in the source tree to inject into the PYTHONPATH for installations that don't have it, which seems... well, okay, I don't know whether the average python installation is likely to remove this, though I don't understand why anyone would unilaterally remove part of the stdlib.

However, why does it then have code to import requests (a new dependency) and then download and revendor the module itself, at runtime? The unittests then seem to want to exercise that right to have the project broken at the source level and then repair it.

If on the other hand I clone the github repository and run dephell deps convert, then dephell_venvs.ensurepip is not in packages and doesn't get installed at all (because I have ensurepip already). But this would add a bootstrap cycle when trying to build dephell from scratch on new versions of python. Plus I'm not entirely sure when and where a vendored version of ensurepip is needed.

@eli-schwartz
Copy link
Author

ping? Can this either be removed, or vendored in properly without dynamically revendoring itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant