Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving symlink real paths for js resolver #81

Open
Diokuz opened this issue Jul 2, 2019 · 1 comment
Open

Resolving symlink real paths for js resolver #81

Diokuz opened this issue Jul 2, 2019 · 1 comment

Comments

@Diokuz
Copy link

Diokuz commented Jul 2, 2019

The problem I have is that syminks are not replaced with their real paths. I found two problems:

  1. https://github.com/browserify/resolve/pull/195/files
  2. filing-cabinet does not allow to set preserveSymlinks: false anyway.

So, I have two questions:

  1. Could you replace browserify/resolve with build-in node resolve? (because the first one have bugs)
  2. Could you set preserveSymlinks: false by default for js resolver? TS resolver has that option by default.

PS: I use yarn workspaces, and all dependencies symlinked through node_modules. But I want to resolve all dependencies through their real paths.

@mrjoelkemp
Copy link
Collaborator

Thanks for the issue. Feel free to open a PR with the adjustments and tests. More than happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants