Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install v6 on TFS 2017 Update 3 #125

Open
wiseman13 opened this issue Feb 24, 2023 · 3 comments
Open

Cannot install v6 on TFS 2017 Update 3 #125

wiseman13 opened this issue Feb 24, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@wiseman13
Copy link

I am trying to install the OWASP Dependency Check extension from the Visual Studio Marketplace for our on prem version of TFS 2017. The version of the plugin is 6.1.0.1 and I get the following message in the event log after trying to install. If I download the vsix and try to upload manually I get the same error.

Team Foundation Server version: 15.117.27414.0

System.ArgumentException: The asset type
'Tasks/dependency-check-build-task/node_modules/@types/concat-stream/index.d.ts'
is invalid. Asset types may only contain 'A' through 'Z', 'a' through 'z', '0'
through '9', '.' and '-'. The asset type can't have more than one consecutive
'.'. at
Microsoft.VisualStudio.Services.Gallery.WebApi.GalleryUtil.CheckAssetType(String
assetType) at
Microsoft.VisualStudio.Services.Gallery.Server.PublishedExtensionService.FixUpFieldsAndValidateCommon(IVssRequestContext
requestContext, IEnumerable1 assets, IEnumerable1 installationTargets,
InstallationTarget[]& installationTargetArray, PublishedExtensionFlags&
flags, Boolean& shouldNotify, Boolean&
isUpdateVstsExtensionInstallationTarget, Boolean isFirstParty) at
Microsoft.VisualStudio.Services.Gallery.Server.PublishedExtensionService.CreateExtensionCommon(IVssRequestContext
requestContext, Stream extensionPackageStream, String requestingPublisherName,
IEnumerable`1 uploadedAssets, Boolean immediateVersionValidation) at
Microsoft.VisualStudio.Services.Gallery.Server.PublishedExtensionService.CreateExtension(IVssRequestContext
requestContext, Stream extensionPackageStream, String requestingPublisherName)
at
Microsoft.VisualStudio.Services.Gallery.Extensions.OnPremPublishedExtensionService.PublishExtensionFromHosted(IVssRequestContext
requestContext, String publisherName, String extensionName, Boolean
onlyUpdateForNewVersion, Boolean blockPreviewToPaidUpgrade)

@wiseman13
Copy link
Author

Just a quick update that I m still looking into this, but have not found any other details that would help me resolve it.

@Saturate
Copy link
Collaborator

Saturate commented Dec 5, 2023

For me it seems like the issue is that we have a package from @types/concat-stream and the @ is not allowed.

It's an issue that we are packaging things only used during build time, this should not be there during run time.

@pippolino Would it make sense for you to look into this while doing the pipeline changes?

@Saturate Saturate added the bug Something isn't working label Dec 5, 2023
@pippolino
Copy link
Collaborator

@Saturate I would like to check the libraries used because some may not be necessary.

For the moment I would like touch as little as possible to have a working version with the yaml pipeline and then I will start checking the other aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants