Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show details from timed-out update runs #2261

Closed
swegner opened this issue May 24, 2018 · 9 comments
Closed

Show details from timed-out update runs #2261

swegner opened this issue May 24, 2018 · 9 comments
Labels
T: feature-request Requests for new features

Comments

@swegner
Copy link

swegner commented May 24, 2018

I just tried integrating dependabot on a personal repo (swegner/beam) using Gradle. I see that dependabot "bumped" an hour ago, but I don't see any output. No pull requests are open, and I can't tell whether I have it properly configured.

It'd be nice if dependabot gave some output about what happened in its last run. On a successful run, this could include:

  1. The head commit used.
  2. What build system was used and what build files it found for that build system
  3. The dependencies detected and their current version
  4. A status for each dependency: whether it is known up-to-date / stale, or unknown.
  5. Action that was take for stale dependencies.
@greysteil
Copy link
Contributor

Thanks for giving Dependabot a try! I've just looked at our logs and can see that, unfortunately, that update run timed out. It's the one status that we don't give any feedback for - I should definitely fix that, at the very least, and will change the title of this issue accordingly.

As a more general point about Dependabot's Gradle support - it's still in Alpha and unlikely to be able to handle large projects like Beam just yet. I'd like to get it there, but it's a way off yet. Our support for every other package manager is a lot more advanced, and I wouldn't expect problems like this one to occur for them.

@greysteil
Copy link
Contributor

It's also worth mentioning that the core for Dependabot is open source over at https://github.com/dependabot/dependabot-core, and if you fancy having a poke around the Gradle support you'd be very welcome! Java is probably my weakest languages, so apologies if it's a bit of a mess right now!

@greysteil greysteil changed the title Logs or output from analysis process? Show details from timed-out update runs May 24, 2018
@swegner
Copy link
Author

swegner commented May 24, 2018

Thanks for the quick feedback. For full transparency, I likely won't have a chance to look into improving Gradle support. But I'll keep an eye on this issue and can give it another try.

@mszabo-wikia
Copy link

Note: this still seems to be an issue for large Gradle projects. Recently we enabled Dependabot for our Gradle monorepo which contains over 110 subprojects; the subprojects were correctly registered but no PRs arrived. Registering some subprojects manually did result in PRs for those subprojects, so this seems to indicate a timeout issue.

@greysteil
Copy link
Contributor

That would make sense - with very large projects like that Dependabot will be making hundreds of calls to GitHub to fetch each of the dependency files (it doesn't clone your repo for security reasons). I'd love to make that better in future.

@infin8x infin8x transferred this issue from dependabot/feedback Jun 29, 2020
@infin8x infin8x added T: feature-request Requests for new features F: infrastructure labels Jul 2, 2020
@erdnaxeli
Copy link

What is the timeout time?

@duhseekoh
Copy link

I'm seeing failures at the 30 minute mark. Our yarn.lock file, which is big, but not out of the ordinary can't be processed by dependabot for within that timeframe for some reason. In the dependabot logs, only a handful of out the many dependencies get checked. We've been missing a lot of updates because of that. :(

@erdnaxeli
Copy link

I'm seeing failures at the 30 minute mark. Our yarn.lock file, which is big, but not out of the ordinary can't be processed by dependabot for within that timeframe for some reason. In the dependabot logs, only a handful of out the many dependencies get checked. We've been missing a lot of updates because of that. :(

I have the same kind of problem with a Pipenv file. It tooks some time when running manually but no more than 5 minutes, I don't understand.

@dependabot dependabot deleted a comment from stale bot Aug 11, 2022
@jeffwidman
Copy link
Member

The code around timeouts has changed a lot since this issue was filed/updated. In fact, it's on a completely new infrastructure backend. So I'm going to close this, but if you are still seeing problems, please file an issue and we can look at what is happening in that specific case.

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

7 participants