diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb index 11cea3bea42..81318254768 100644 --- a/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb +++ b/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb @@ -252,7 +252,10 @@ def types_update_available? return false unless latest_allowable_version.backwards_compatible_with?(latest_types_package_version) + return false unless version_class.correct?(types_package.version) + current_types_package_version = version_class.new(types_package.version) + return false unless current_types_package_version < latest_types_package_version true @@ -261,9 +264,12 @@ def types_update_available? def original_package_update_available? return false if original_package.nil? - latest_version = latest_version_finder(original_package).latest_version_from_registry + return false unless version_class.correct?(original_package.version) + original_package_version = version_class.new(original_package.version) + latest_version = latest_version_finder(original_package).latest_version_from_registry + original_package_version < latest_version end