-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Breaking Changes in v4.0.0 #4603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As the author of the original vim virtual text emulation, I propose to remove that specific compatibility code (i.e. emulating virtual text with popup-windows). It is a total hack, has various edge cases where it is outright bugged (e.g. try it in split windows) and I replaced it with proper virtual text from vim9 a while ago. The emulated virtual text also targets only a very limited number of vim versions, as it requires features from late vim 8.2, but proper virtual text is available with early vim 9.0. To avoid people being confused with buggy virtual text, I think it would be better to only provide the proper virtual text implementation. Also |
@vimpostor I'm keeping Vim 8.0 support for this version of ALE. I'll still wait a few years before I make Vim 9.0 the minimum supported version, and then we can remove a huge chunk of code from the ALE codebase. |
Virtual text emulation requires vim 8.2 |
There is a mismatch between documentation and implementation for A more correct fix might perhaps be to update the implementation, as the variable name with a repeated |
This issue lists features removed and other breaking changes in ALE v4.0.0.
Removed Features
:ALEInfoToClipboard
- Use:ALEInfo -clipboard
or the plug mapping instead.g:ale_linters_sh_shell_default_shell
has been removed. Useg:ale_sh_shell_default_shell
instead.g:ale_linters_sh_shellcheck_exclusions
has been removed. Useg:ale_sh_shellcheck_exclusions
instead.ale_lsp_root
setting is no longer supported. Useale_root
instead.Older Tools Support Removed
ember-template-lint
versions below 1.6.0 are no longer supported.Other Breaking Changes
ve-py3
directory name is no longer among the names ALE searches for by default for virtualenv directories. Set yourg:ale_virtualenv_dir_names
setting if you still need it.New Deprecations
ale_deno_import_map
option for the Deno import map instead ofale_deno_importMap
.The text was updated successfully, but these errors were encountered: