Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax for "deno.suggest.imports.hosts" (Rename property?) #395

Closed
jsejcksn opened this issue Apr 16, 2021 · 1 comment
Closed

Syntax for "deno.suggest.imports.hosts" (Rename property?) #395

jsejcksn opened this issue Apr 16, 2021 · 1 comment
Labels
declined This suggestion was respectfully declined

Comments

@jsejcksn
Copy link
Contributor

jsejcksn commented Apr 16, 2021

The documentation states this:

Configuration

Settings for configuring registries for auto completions:

  • deno.suggest.imports.hosts - These are the origins that are configured to
    provide import completions. The target host needs to support Deno import
    completions (detailed below). The value is an object where the key is the host
    and the value is if it is enabled or not. For example:

    {
      "deno.suggest.imports.hosts": {
        "https://deno.land/": true
      }
    }

However, I'm confused about the host value in the example, because it not a valid host. It is also not a valid origin because it ends in a / (which would also be invalid for a host — it is part of the path[name]).

Here are references for juxtaposing those components of a URL (they include links to the specs):

So here are my questions:

  1. Is the slash simply a typo in the documentation?
  2. Should each key of that property be valid host, hostname, or origin (or some other type)?

If the values should be hostnames or origins, then I think the property should reflect that by being renamed. e.g. deno.suggest.imports.hostnames or deno.suggest.imports.origins

@kitsonk kitsonk added the declined This suggestion was respectfully declined label Jul 19, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Jul 19, 2021

While it might not be 100% correct, it was the form used in the version 2.0 of the extension, and it is documented, and there are lots of people who have it configured. I don't think the naming causes confusion, and if there is any confusion, it is documented. Respectfully declined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined This suggestion was respectfully declined
Projects
None yet
Development

No branches or pull requests

2 participants